-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix python wrapper after upgrading electionguard to 1.2.3 #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
…dim-bulletin-board into update-electionguard-1.2.3
…ages/libgmp/Makefile Co-authored-by: Andrés Pereira de Lucena <[email protected]>
…dim-bulletin-board into update-electionguard-1.2.3
# Conflicts: # Dockerfile.release
microstudi
force-pushed
the
fix-python-wrapper
branch
from
September 25, 2023 20:57
30311bd
to
eff4f95
Compare
andreslucena
requested changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some doubts, can you check them out please?
Co-authored-by: Andrés Pereira de Lucena <[email protected]>
andreslucena
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After updating to ElectionGuard 1.2.3 the libray
electionguard.types
has been renamed in the python package. This PR adapts this to the pyodide wrapper.This PR also organizes a bit better the different Dockerfiles (I guess there are 3 because of heroku, but only Dockerfile is needed in order to work).